Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip installable up to python 3.9 #389

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Conversation

c-martinez
Copy link
Collaborator

Tested for Pythons 3.6.15 | 3.7.16 | 3.8.16 | 3.9.16 as follows:

virtualenv py3X --python python3X
source py3X/bin/activate
pip install .
pip install -r requirements-test.txt
pytest tests/
deactivate

(where the X is the python version 6, 7, 8 or 9)

@c-martinez
Copy link
Collaborator Author

Addresses #386

@c-martinez c-martinez mentioned this pull request Jan 24, 2023
@c-martinez
Copy link
Collaborator Author

As part of testing this, we should make sure Github Action for testing passes tests for all versions of Python included here (6 to 9)

@rapw3k
Copy link

rapw3k commented Feb 2, 2023

Hi @c-martinez i was testing for python 3.9 and it build ok...

@c-martinez
Copy link
Collaborator Author

Great, thanks for testing @rapw3k , good to know it not only works on my computer :-)

@c-martinez
Copy link
Collaborator Author

It looks like it is building properly in GitHub actions for all versions.

I think we can merge this, unless you see any issues @albertmeronyo ?

@c-martinez c-martinez merged commit 26ca5a0 into CLARIAH:dev Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants