Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_surge_from_track after change in Holland 2008 implementation… #107

Merged

Conversation

ThomasRoosli
Copy link
Collaborator

@ThomasRoosli ThomasRoosli commented Jan 18, 2024

… (climada_python PR #833)

Changes proposed in this PR:

This PR fixes #842 in climada_python CLIMADA-project/climada_python#842

PR Author Checklist

PR Reviewer Checklist

Copy link
Collaborator

@tovogt tovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also noticed this while working on #105, and fixed it there. But I think it's good to have a separate PR for this here.

@emanuel-schmid
Copy link
Contributor

🚀 Many thanks! 🙌

@emanuel-schmid emanuel-schmid merged commit 75a7536 into develop Jan 19, 2024
4 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/fixTCSurgeBathtub_after_climadapython_PR833 branch January 19, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants