Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/river flooding aqueduct #108

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from

Conversation

aleeciu
Copy link
Collaborator

@aleeciu aleeciu commented Jan 26, 2024

Similarly to #100 , this PR integrates Aqueduct's Fluvial global flood data in CLIMADA

@bguillod
Copy link
Collaborator

I'll review this one as soon as #111 is merged into develop, because otherwise I now see changes from both branches in this PR.

@chahank
Copy link
Member

chahank commented Apr 29, 2024

@bguillod sounds good! Can you please see with @aleeciu to finish #111 then?

@emanuel-schmid
Copy link
Contributor

@bguillod #111 has just been merged

@emanuel-schmid
Copy link
Contributor

@bguillod #111 has just been un-merged, due to a failing integration test

@chahank
Copy link
Member

chahank commented Nov 21, 2024

@aleeciu @bguillod Do you think that you can fix the integration test?

@aleeciu
Copy link
Collaborator Author

aleeciu commented Dec 13, 2024

From my end this PR is complete.
Similarly to #153 and #100 I seem to be getting test errors about wind calculation. I don't know where this comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants