Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only assign csr matrices to Hazard objects #129

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

peanutfun
Copy link
Member

@peanutfun peanutfun commented Jun 14, 2024

Changes proposed in this PR:

  • Use intermediate variables if LIL matrices are used.
  • Write all-zero fraction matrix instead of all-ones (all-zero fractions are treated as ones).

This PR fixes compatibility issues arising from CLIMADA-project/climada_python#893

PR Author Checklist

PR Reviewer Checklist

* Use intermediate variables if LIL matrices are used.
* Write all-zero fraction matrix instead of all-ones
  (all-zero fractions are treated as ones).
@peanutfun peanutfun requested a review from chahank June 21, 2024 13:32
Copy link
Member

@chahank chahank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@peanutfun peanutfun merged commit 13fd366 into develop Jun 24, 2024
11 checks passed
peanutfun added a commit that referenced this pull request Jun 25, 2024
* Fix matrix assignment in WildFire
  (leftover from #129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants