Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of IBtracs file. #152

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

chahank
Copy link
Member

@chahank chahank commented Dec 9, 2024

Changes proposed in this PR:

PR Author Checklist

PR Reviewer Checklist

@chahank
Copy link
Member Author

chahank commented Dec 9, 2024

The test in Python 3.9 and 3.10 seem to be failing because the unit tests then need another writing for skipping a test (in this case, the test is skipped if the IBTrACS file cannot be downloaded). I propose to keep it as it is now since this should work for Python 3.11 and higher.

@emanuel-schmid
Copy link
Contributor

🙌

@emanuel-schmid emanuel-schmid merged commit 94f68ae into develop Dec 11, 2024
11 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/update_ibtracs_version branch December 11, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants