Complete restructuring of the SupplyChain module

[aleeciu]

This pull request features a complete restructuring of the supply chain module, including:

• two subtle bug fixes
• the use of pymrio (https://pymrio.readthedocs.io/en/latest/intro.html) to download and handle multi-regional input output tables
• restructuring of operations which sped up the code substantially

[aleeciu]

Hi @emanuel-schmid, in this pull request I am using the pymrio module (https://pymrio.readthedocs.io/en/latest/index.html) which is currently not included in the CLIMADA environment. How shall I add it?

[emanuel-schmid]

Yes, this problem is currently not really solved.

There are workarounds though: one can add a line pip install pymrio in script/branches/Jenkinsfile. With this, the environment is updated before running unit-tests on Jenkins. (I just did this and the tests ran through)

However, this file should actually remain unchanged in the develop branch and requirements/env_climada.yaml should be changed instead. You can update env_climada.yaml anytime in this branch but it won't have an effect on the environment, which is defined by the develop branch alone. On the other hand, the changes in the Jenkinsfile be undone before or after merging. (They don't hurt but the slow down the unittests for a couple of seconds for each commit.)

For now I suggest to proceed like this and I'll clean up the Jenkinsfile after the PR has been merged.

[aleeciu]

Great, thanks @emanuel-schmid for the clarification. I will then update the requirements/env_climada.yaml in develop after merging. One more question: I keep getting a readthedocs error but I am not quite sure how to fix/interpret it.

[peanutfun]

I keep getting a readthedocs error but I am not quite sure how to fix/interpret it.

@aleeciu Try merging the latest version of develop back into this branch

[aleeciu]

I keep getting a readthedocs error but I am not quite sure how to fix/interpret it.

@aleeciu Try merging the latest version of develop back into this branch

great, it worked thanks

[peanutfun]

@emanuel-schmid could you add pymrio to the Petals environment, so that we can remove this line here?

[aleeciu]

Many thanks @peanutfun; I am confused because I saw some suggested changes from your side but now they are marked as resolved. It's all good for me if you implemented them directly, just please let me know if changes are still expected from my side.

ps
I did not mean to urge you few days ago by reminding you about the review - I just pressed the button by mistake :-)

[peanutfun]

@aleeciu I now marked the comments as resolved. Some were outdated and for others I am not familiar enough with the module to mess with it now. If you are fine with how it works, I think we can merge 🙂

[aleeciu]

we can merge from my side, and we still have #81 which will bring changes to this module