Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact.select() reset_frequency option #830

Closed
timschmi95 opened this issue Dec 15, 2023 · 4 comments
Closed

Impact.select() reset_frequency option #830

timschmi95 opened this issue Dec 15, 2023 · 4 comments
Labels
accepting pull request Contribute by raising a pull request to resolve this issue! user-friendliness

Comments

@timschmi95
Copy link
Collaborator

Currently, Hazard.select() has a reset_frequency option, but Impact.select() doesn't.
I have the use case of having an impact object which is not created through ImpactCalc (i.e. not from any hazard object) and need to select a subsample (e.g. only the last 10 years). In order to get the correct exceedance frequency curve, I need to manually adjust the frequency of the new impact object after the selection.
Do you think this is a common enough use case to add a reset_frequency option to impact.select(), equivalent to hazard.select()?

@chahank
Copy link
Member

chahank commented Jan 11, 2024

I think this is reasonable yes.

@peanutfun peanutfun added the accepting pull request Contribute by raising a pull request to resolve this issue! label Jan 12, 2024
@peanutfun
Copy link
Member

@timschmi95 Would you have the capacity to provide a pull request?

@timschmi95
Copy link
Collaborator Author

Not at the moment, but I should be able to provide a pull request within the next one/two months.

@peanutfun
Copy link
Member

Resolved by #847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting pull request Contribute by raising a pull request to resolve this issue! user-friendliness
Projects
None yet
Development

No branches or pull requests

3 participants