-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add impact.select reset_frequency option #847
Conversation
@emanuel-schmid All tests are failing due to missing internet connection. Is this a temporary issue or do I need to change something? |
@timschmi95 An issue with the data API firewall. Will probably take until next week to be resolved |
may still fail due to a problem with the installation environment but at least the firewall issue is solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this nice contribution! 🙌 I have a few minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @timschmi95 🎉
Changes proposed in this PR:
This PR fixes #830
PR Author Checklist
develop
)PR Reviewer Checklist