Set all Hazard attributes in __init__ #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is backwards compatible as all defaults remain the same
12 tasks
In order to be compatible with the planed changes to the fraction attribute (if empty, it is ignored), the fraction should by default be derived from the shape of the intensity attribute.
* Add kwargs for HazardTag * Fix type hinting
…ADA-project/climada_python into feature/hazard-init-minimal
|
@peanutfun : I modified the |
|
Very good, I already merged it with my changes. This is ready to go (if all tests pass 🙃 ) |
peanutfun
changed the title
|
@emanuel-schmid I merged the latest |
simonameiler
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Set all Hazard attributes via __init__ This change is backwards compatible as all defaults remain the same * Add type hinting to Hazard.__init__ * Make fraction default size the same as intensity In order to be compatible with the planed changes to the fraction attribute (if empty, it is ignored), the fraction should by default be derived from the shape of the intensity attribute. * Update Hazard.__init__ signature and docstring * Add kwargs for HazardTag * Fix type hinting * Adapt unit tests to new Hazard constructor * Update tutorials to new Hazard constructor * Add test for initializing Hazard without fraction * undo re-plotting Co-authored-by: Chahan Kropf <chahan.kropf@posteo.com> Co-authored-by: emanuel-schmid <schmide@ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Hazardattributes as optional arguments to theHazard.__init__This PR fixes issue #
PR Author Checklist
develop)PR Reviewer Checklist