Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/init tc tracks #559

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Feature/init tc tracks #559

merged 8 commits into from
Nov 3, 2022

Conversation

manniepmkam
Copy link
Collaborator

@manniepmkam manniepmkam commented Oct 26, 2022

Changes proposed in this PR:

This PR fixes issue #

PR Author Checklist

PR Reviewer Checklist

@peanutfun peanutfun self-assigned this Oct 27, 2022
def __init__(self, pool=None):
def __init__(self,
data: Optional[List[xr.Dataset]] = None,
pool: Optional[pathos.multiprocessing.ProcessPool] = None):
"""Create new (empty) TCTracks instance.

Parameters
----------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pydoc parameter description for data is missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: b7c6b80

@emanuel-schmid
Copy link
Collaborator

🙌

@emanuel-schmid emanuel-schmid merged commit 32b4958 into develop Nov 3, 2022
@emanuel-schmid emanuel-schmid deleted the feature/init_tc_tracks branch November 3, 2022 14:45
simonameiler pushed a commit that referenced this pull request Aug 24, 2023
* update __init__ in tc_tracks.py

* update tc_tracks.py

* update tc_tracks.py

* remove trailing white space

* Update usage of TCTracks.__init__

* Update TCTracks.__init__ docstring

Add information on `data` parameter.

Co-authored-by: emanuel-schmid <schmide@ethz.ch>
Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants