Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of tutorials: spelling and bugs #582

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

NicolasColombi
Copy link
Collaborator

@NicolasColombi NicolasColombi commented Nov 15, 2022

Changes proposed in this PR:

  • Change in cell 14 of tutorial 1_main_climada.jpynb An extra comma "," was making an array behave like a tuple.
  • Change in cell 2 of climada_engine_Forecast.jpynb Spelling mistake: there was two times in a row the word "with" and two times ##

This PR fixes

  1. A bug in the file climada/doc/tutorial/1_main_climada.jpynb
  2. A spelling mistake in the file climada/doc/tutorial/climada_engine_Forecast.jpynb

PR Author Checklist

PR Reviewer Checklist

NicolasColombi and others added 2 commits November 15, 2022 17:45
1) First correction: Change in cell 14 of tutorial 1_main_climada.jpynb
An extra comma "," was making an array behave like a tuple.

1) Second correction: Change in cell 2 of climada_engine_Forecast.jpynb
Spelling mistake: there was two times in a row the word "with" and two
times ##
@emanuel-schmid
Copy link
Collaborator

👍 I just undid the re-plotting. I'll merge once the tests have passed.

@emanuel-schmid emanuel-schmid merged commit cd6dcf8 into develop Nov 16, 2022
@emanuel-schmid emanuel-schmid deleted the feature/tutorials branch November 16, 2022 09:38
simonameiler pushed a commit that referenced this pull request Aug 24, 2023
* Correction of tutorials: spelling and bugs

1) First correction: Change in cell 14 of tutorial 1_main_climada.jpynb
An extra comma "," was making an array behave like a tuple.

1) Second correction: Change in cell 2 of climada_engine_Forecast.jpynb
Spelling mistake: there was two times in a row the word "with" and two
times ##

* undo replotting

Co-authored-by: Nicolas Colombi <ncolombi@student.ethz.ch>
Co-authored-by: emanuel-schmid <schmide@ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants