Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tutorial #617

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Feature/tutorial #617

merged 5 commits into from
Jan 16, 2023

Conversation

NicolasColombi
Copy link
Collaborator

@NicolasColombi NicolasColombi commented Jan 9, 2023

Changes proposed in this PR:

  • Fix typos in Litpop tutorial
    1) grided-> gridded
    2) diaggregation -> disaggregation

  • Change climate scenario in cost-benefit tutorial
    1) rcp85 --> rcp60

This PR fixes:

Cost benefit tutorial

PR Author Checklist

PR Reviewer Checklist

The first cell of cost benefit tutorial was broken because the
climate scenario used was 'rcp85', which is not present in
the following list of defined scenarios:
['rcp26', 'rcp45', 'rcp60', 'historical'].

Replace 'rcp85' with 'rcp60', adpat documentation.
1) grided-> gridded
2) diaggregation -> disaggregation
@emanuel-schmid emanuel-schmid marked this pull request as draft January 12, 2023 12:54
@NicolasColombi NicolasColombi marked this pull request as ready for review January 12, 2023 15:44
@emanuel-schmid emanuel-schmid marked this pull request as draft January 13, 2023 12:31
@emanuel-schmid emanuel-schmid marked this pull request as ready for review January 16, 2023 10:54
@emanuel-schmid emanuel-schmid merged commit 2dd8b39 into develop Jan 16, 2023
@emanuel-schmid emanuel-schmid deleted the feature/tutorial branch January 16, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants