Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/haz type in step impf #675

Merged
merged 10 commits into from
Mar 29, 2023
Merged

Feature/haz type in step impf #675

merged 10 commits into from
Mar 29, 2023

Conversation

chahank
Copy link
Member

@chahank chahank commented Mar 20, 2023 •
edited by leonie-villiger
Loading

Changes proposed in this PR:

  • Make it obligatory for the sigmoid and step function methods to have haz_type defined
  • Pass kwargs to the ImpactFunc init

PR Author Checklist

PR Reviewer Checklist

@chahank chahank changed the base branch from main to develop March 20, 2023 13:59
@chahank chahank requested a review from leonie-villiger March 20, 2023 13:59
leonie-villiger
leonie-villiger reviewed Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@leonie-villiger leonie-villiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing the keyword argument haz_type into _ImpactFunc_´s classmethods from_step_impf and from_sigmoid_imp ! Please find some minor comments in the Files changed.

CHANGELOG.md Outdated Show resolved Hide resolved
climada/entity/impact_funcs/base.py Show resolved Hide resolved
climada/entity/impact_funcs/base.py Show resolved Hide resolved
climada/entity/impact_funcs/base.py Show resolved Hide resolved
climada/entity/impact_funcs/test/test_base.py Outdated Show resolved Hide resolved
climada/entity/impact_funcs/test/test_base.py Outdated Show resolved Hide resolved
climada/entity/impact_funcs/test/test_base.py Outdated Show resolved Hide resolved
climada/entity/impact_funcs/test/test_base.py Outdated Show resolved Hide resolved
climada/entity/impact_funcs/test/test_base.py Outdated Show resolved Hide resolved
chahank and others added 4 commits March 29, 2023 16:58
@chahank @leonie-villiger
Update CHANGELOG.md
e951200 
Co-authored-by: leonie-villiger <87335708+leonie-villiger@users.noreply.github.com>
@chahank @leonie-villiger
Update climada/entity/impact_funcs/test/test_base.py
cb41852 
Co-authored-by: leonie-villiger <87335708+leonie-villiger@users.noreply.github.com>
Update docstring
41b9db6
Make test for step and sigmoid consistent
c280b92
@chahank
Copy link
Member Author

chahank commented Mar 29, 2023

Thanks a lot for the thorough review! I think I addressed all points.

@leonie-villiger leonie-villiger mentioned this pull request Mar 29, 2023
Open
@leonie-villiger leonie-villiger merged commit a3d189a into develop Mar 29, 2023
@leonie-villiger leonie-villiger deleted the feature/haz_type_in_step_impf branch April 20, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonie-villiger leonie-villiger leonie-villiger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chahank @leonie-villiger