Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for numpy arrays in hazard select #719

Merged
merged 1 commit into from
May 11, 2023
Merged

Allow for numpy arrays in hazard select #719

merged 1 commit into from
May 11, 2023

Conversation

chahank
Copy link
Member

@chahank chahank commented May 11, 2023

Changes proposed in this PR:

  • The hazard.select Method was setup to only accept lists and silently ignore numpy arrays. This is fixed now. Instead of checking for specific types, it only checks whether the attributes are None.

This PR fixes

PR Author Checklist

PR Reviewer Checklist

@samluethi samluethi merged commit f0fd3a5 into develop May 11, 2023
@chahank chahank mentioned this pull request May 12, 2023
Merged
13 tasks
@emanuel-schmid emanuel-schmid deleted the bugfix/hazard_select_nparray branch May 25, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chahank @samluethi