-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging best practice #724
Conversation
changelog: add PR number
Thanks @emanuel-schmid, this implementation looks very clean to me! I would be happy if somebody came up with a more fitting name for the config parameter instead of |
Thanks @tovogt . Changed it to |
# Conflicts: # CHANGELOG.md
I'm happy with this PR conceptually. Please just don't forget to update the name of the config parameter ("managed" or "climada_style" or whatever) in the CHANGELOG and in the docs, once the decision for the name is final. |
Changes proposed in this PR:
logging.climada_style
that controls whether or not the logging is configured in the traditional climada style.This PR fixes #265
PR Author Checklist
develop
)PR Reviewer Checklist