-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub actions for unit testing #745
Conversation
* Move file checks to integration tests. They require file downloads. * Fix assertion for almost equal arrays.
The unsequa module throws segmentation faults while unit testing.
I tried to achieve compatibility also with Python 3.11, but the unsequa module causes segmentation faults there, see https://github.com/CLIMADA-project/climada_python/actions/runs/5890648735/job/15976187422. I think this is due to the process pool. Maybe #763 will resolve these issues, but we will have to look out. |
The build in 3.10 also fails, but because of another module. Can this be easily fixed? |
All checks have passed for the latest commit. What are you referring to? 🤔 |
I was referring to the link https://github.com/CLIMADA-project/climada_python/actions/runs/5890648735/job/15976187422 |
This was the test result of an earlier commit. The particular error was resolved by 109d994 |
.github/workflows/ci.yml
Outdated
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.9", "3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we then have to update manually for each release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each Python release, yes.
Looks good to me if this does what it should do which I cannot tell from looking at the code only. Maybe @emanuel-schmid can confirm? |
@chahank @emanuel-schmid How and where should I document this? (topics: What does the pipeline do, how to inspect results and coverage reports, etc) |
This apparently was resolved by #763. Excellent work, @chahank! |
I would highly appreciate your comments on this. Apart from that, the branch is ready to be merged. |
Well - there is https://github.com/CLIMADA-project/climada_python/blob/main/doc/guide/Guide_Continuous_Integration_and_Testing.ipynb where it wouldn't be completely out of place. |
From personal discussion: I'll add a documentation of the pipeline itself but not make it part of the guides for testing yet. |
* Add introduction to GitHub Actions to the docs. * Add information to the CI guide. * Improve comments in the ci.yml workflow definition.
Changes proposed in this PR:
setup.py
and environment filedefault_factory
to initialize mutable default values for dataclassPR Author Checklist
develop
)PR Reviewer Checklist