Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set save_mat=False #746

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Set save_mat=False #746

merged 2 commits into from
Jul 6, 2023

Conversation

chahank
Copy link
Member

@chahank chahank commented Jul 5, 2023

Changes proposed in this PR:

  • This sets the variable ImpactCalc.impact(save_mat=False) to False in the unsequa module only. Since the change to the ImpactCalc class, the default was changed from False to True, thus it needs to be set explicitly now. This is important as it cost memory and computation time, while the information cannot be processed in the unsequa module at the moment.

PR Author Checklist

PR Reviewer Checklist

@chahank chahank requested a review from peanutfun July 5, 2023 15:24
@chahank
Copy link
Member Author

chahank commented Jul 5, 2023

If you accept the fix, I will update the changelog.

Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chahank Can you clarify in the PR description that this only affects the Unsequa module? Also, a Changelog entry is missing 🙃 Apart from that, everything looks good! 👌

@chahank chahank merged commit b4cafc1 into develop Jul 6, 2023
@emanuel-schmid emanuel-schmid deleted the bugfix/unsequa_save_mat_true branch August 11, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants