Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_client: allow searching for None #752

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Jul 12, 2023

Changes proposed in this PR:

  • Small change so that the api_client.Client.list_dataset_infos accepts None as a property value.
    So far only strings and list of strings were accepted. This allows looking for unset properties with the more intuitive None.
    Before one had to look for "", an empty string.

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid requested a review from zeliest July 12, 2023 09:54
@emanuel-schmid
Copy link
Collaborator Author

🙌 thanks for the review!

@emanuel-schmid emanuel-schmid merged commit 7283ee8 into develop Jul 14, 2023
@emanuel-schmid emanuel-schmid deleted the feature/search_for_None branch July 14, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants