Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tag attribute from ImpactFuncSet #753

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Remove Tag attribute from ImpactFuncSet #753

merged 5 commits into from
Jul 13, 2023

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Jul 12, 2023 •
edited
Loading

Changes proposed in this PR:

  • simply remove the attribute, leaving out any descriptions when initializing an object

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid changed the base branch from main to develop July 12, 2023 12:27
peanutfun
peanutfun requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Again, the tutorial still mentions the tag and needs to be updated

@peanutfun peanutfun merged commit 4e01450 into develop Jul 13, 2023
@emanuel-schmid emanuel-schmid deleted the feature/remove_tags_impfset branch July 13, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peanutfun peanutfun peanutfun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emanuel-schmid @peanutfun