Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move package data #781

Merged
merged 4 commits into from
Sep 19, 2023
Merged

move package data #781

merged 4 commits into from
Sep 19, 2023

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Sep 6, 2023

Changes proposed in this PR:

  • Move data directory into the climada package directory in order to better isolate the climada package and avoid environment naming conflicts
  • Analogous to PR climda-petals: #90

PR Author Checklist

PR Reviewer Checklist

Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! All files are moved, the new directory is installed correctly with pip install, and importing Climada afterwards works. I searched for instances in the scripts and docs where the path might not have been updated but I found none.

@peanutfun peanutfun merged commit e9d8873 into develop Sep 19, 2023
4 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/package_data branch September 20, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants