Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye Stamen #798

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Goodbye Stamen #798

merged 6 commits into from
Nov 3, 2023

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Oct 27, 2023

Changes proposed in this PR:

  • replace the default tiles provider to use OpenStreetMap instead of StamenTerrain

This PR fixes #796

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid changed the title Feature/bye stamen Goodbye Stamen Oct 27, 2023
# Conflicts:
#	requirements/env_climada.yml
Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this! ☺️

climada/util/api_client.py Show resolved Hide resolved
@peanutfun peanutfun merged commit 98fccb7 into develop Nov 3, 2023
10 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/bye_stamen branch November 8, 2023 10:18
@peanutfun peanutfun mentioned this pull request Nov 22, 2023
@rogerilesdr
Copy link

Hi Lukas, I'm running the latest core CLIMADA release v4.01 on Anaconda which still has the Stamen issue. I was just interested to know when an update with the resolution will be released so I can decide whether to look for a temporary workaround?
Thanks, Roger

@peanutfun
Copy link
Member

@rogerilesdr The workaround is to specify a different provider in the Impact method parameters, e.g.,

import contextily as ctx
impact.plot_basemap_eai_exposure(url=ctx.providers.CartoDB.Positron)

@peanutfun
Copy link
Member

@gaelleclain @rogerilesdr On second thought, I am not sure if that fix helps because the code in impact.py still includes the provider which does not exist anymore. You might need to use the development version of Climada, following the "Advanced Instructions" for installation until our next release.

@rogerilesdr
Copy link

That's OK, I've done a dirty workaround for now, I've manually updated the files changed, rather than using the development version for now. I'll overwrite these files when the next stable release arrives.

@gaelleclain
Copy link

@rogerilesdr can you please give a few details on your workaround?

  • Did you update any other file than impact.py?
  • Did you do anything else before testing?

Thanks

@rogerilesdr
Copy link

I updated the .py files listed on the Files tab above, which also shows where they're located... namely...

  • test_plot.py
  • impact.py
  • base.py
  • api_client.py

@peanutfun
Copy link
Member

@rogerilesdr @gaelleclain Another fix I missed before is to revert xyzservices to version 2023.7.0 after installing Climada. This will still require to use the fix above for the plots themselves, but at least you should be able to load and execute Climada modules without any code modification.

@peanutfun
Copy link
Member

@rogerilesdr @gaelleclain The latest update to our Conda package reverts xyzservices in the dependency list and should resolve the issue. Update the package with mamba update -n climada_env climada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants