Meson: fixes, cleanups, and modernizations #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I picked 0.60 because it's a older, but it's also the version that adds the `meson.override_dependency()` function, which is the modern mechanism to declare a dependency to a parent scope. Without a minimum version set, Meson will not give warnings about deprecations or feature misuses.
This allows consumers to replace
`subproject('CLI11').get_variable('CLI11_dep')` with the same
`dependency('CLI11')` call that they would be using to discover via
pkg-config.
There are a couple of distinct issues here:
1. The tests don't actually depend on the helpers, so they wont be
built automatically
2. The paths encoding by the pre-processor is relative, but there's no
guarantee as to where they'll run. As such, encode an absolute path.
An alternative would be to pass them as arguments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 17
Lines 4546 4557 +11
Branches 0 971 +971
==========================================
+ Hits 4546 4557 +11 ☔ View full report in Codecov by Sentry. |
|
It would be nice to have a bit of documentation on the modern way to use it, but this seems like a nice cleanup! |
henryiii
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series cleans up and modernizes the Meson code a bit: