Improved clarity in RequiredError #1029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Thank you for this tool.
I found a few small typos in the RequiredError class.
This is an error message I received:
This PR changes the error message to
Happy to make changes as needed!
Source
Further Idea
Also, another idea I had was to remove required options from this error message. In this example, "filename" is required, so a better error message would be
I'm happy to look into this if you feel it would be valuable