Skip to content

Conversation

@phlptp
Copy link
Collaborator

@phlptp phlptp commented Aug 28, 2025

generating a seg fault if no default and no config file provided.

Fixes #1197

This was likely introduced by the combination of fixes for some issues with the config parsing and some updates to the as method a while back. This edge case on the handling of the config pointer with as was not overlooked in the earlier testing.

@phlptp phlptp added the bug label Aug 28, 2025
@phlptp
Copy link
Collaborator Author

phlptp commented Aug 28, 2025

this edge case could also apply if someone was manipulating and running an option callback outside of the app. The fix resolves both situations.

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e4ee3af) to head (44b50f0).
⚠️ Report is 117 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1199     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           17        17             
  Lines         4546      5180    +634     
  Branches         0      1064   +1064     
===========================================
+ Hits          4546      5180    +634     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phlptp phlptp merged commit f7e4695 into CLIUtils:main Aug 29, 2025
62 checks passed
@phlptp phlptp deleted the config_seg_fault_fix branch August 29, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code that runs correctly with version 2.3.2 produces a seg-fault when built and executed with version 2.5.0.

1 participant