Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filter fn to simplify, sort includes #120

Merged
merged 1 commit into from
May 6, 2018
Merged

Use filter fn to simplify, sort includes #120

merged 1 commit into from
May 6, 2018

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 6, 2018

Small cleanups:

  • Sort includes is now working
  • lname and sname have getters
  • get_parent works in const settings
  • Group printing by CLI::Formatter has been refactored to use filters
  • help all printing cleaned up
  • Added make_positionals(app) for users to override if desired

@codecov
Copy link

codecov bot commented May 6, 2018

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #120   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines        1647   1646    -1     
=====================================
- Hits         1647   1646    -1
Impacted Files Coverage Δ
include/CLI/StringTools.hpp 100% <ø> (ø) ⬆️
include/CLI/Validators.hpp 100% <ø> (ø) ⬆️
include/CLI/FormatterFwd.hpp 100% <ø> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Formatter.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff6fca...8bc37ca. Read the comment docs.

@henryiii henryiii merged commit 101d847 into master May 6, 2018
@henryiii henryiii deleted the cleanup branch May 6, 2018 16:36
@henryiii henryiii added this to the v1.6 milestone Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant