Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better help-all, prints more info, better spacing #163

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Sep 6, 2018

This fixes issues found in #161 related to printing out subcommands.

  • Printing help-all on nested command now fixed (App)
  • Missing space after help-all restored (Default formatter)
  • More detail printed on help all (Default formatter)
  • Help-all subcommands get indented with inner blank lines removed (Default formatter)
  • detail::find_and_replace added to utilities

An example of output now:

$ ./examples/nested camera --help-all
Configure the app camera
Usage: ./examples/nested camera [OPTIONS] [SUBCOMMAND]

Options:
  -h,--help                   Print this help message and exit
  --help-all                  Expand all help

Subcommands:
mvcamera
  MatrixVision Camera Configuration
  Options:
    -c,--config FILE=mvcamera_config.json
                                Config filename

mock
  Mock Camera Configuration
  Options:
    -p,--path PATH REQUIRED     Path

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #163   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1691   1699    +8     
=====================================
+ Hits         1691   1699    +8
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Formatter.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4389b33...fd52fd4. Read the comment docs.

@henryiii henryiii merged commit e04498c into master Sep 6, 2018
@henryiii henryiii deleted the helpall branch September 6, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant