Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making mutable sets explicit #200

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Making mutable sets explicit #200

merged 1 commit into from
Jan 24, 2019

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jan 23, 2019

This steps back from the design from #113, where mutable sets were implicit, and makes them explicit (add_mutable_set, etc.). This way a new user is less likely to be caught with a surprise segfault when they let their set go out of scope after an innocuous add_set. This is a temporary patch for 1.7; 1.8 hopefully will feature a new CLI::Set design that will remove the huge number of different add_set variants. Closes #170.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #200 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage     100%   99.89%   -0.11%     
==========================================
  Files          12       12              
  Lines        1908     1908              
==========================================
- Hits         1908     1906       -2     
- Misses          0        2       +2
Impacted Files Coverage Δ
include/CLI/App.hpp 99.76% <100%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7aefe...990dabb. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1908   1908           
=====================================
  Hits         1908   1908
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7aefe...d99a377. Read the comment docs.

@henryiii henryiii merged commit 02c4938 into master Jan 24, 2019
@henryiii henryiii deleted the henryiii-mutable branch January 24, 2019 09:10
@henryiii henryiii added this to the v1.7 milestone Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant