Support user defined delimiter when parsing list

[rafiw]

Currently user can only parse list with spaces
E.g app -o 1 2 3
now use can define his own one char delimiter e.g comma

[codecov]

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #209   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1932   1933    +1     
=====================================
+ Hits         1932   1933    +1

Impacted Files	Coverage Δ
include/CLI/App.hpp	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd04e3...5228390. Read the comment docs.

[codecov]

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #209   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1960   1964    +4     
=====================================
+ Hits         1960   1964    +4

Impacted Files	Coverage Δ
include/CLI/App.hpp	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4910df...434a247. Read the comment docs.

[henryiii]

Please add a few tests, including at least the following cases:

-v 1 2
-v 1,2
-v 1,2,
-v 1, 2
-v "1,2"
-v "1, 2 "

I believe space will always be a separator, since this is what gets passed to CLI11 from argc, argv.

[henryiii]

I can fix the style pretty trivially if needed. Is there a version with defaults to add too?

[henryiii]

This should be added in the

Option *add_option(std::string option_name,
                       std::vector<T> &variable, ///< The variable vector to set
                       std::string description,
                       bool defaulted)

one too, right below, and matching tests copied and pasted in.

[rafiw]

i will update next week

[rafiw]

@henryiii there are some style issues not related to my changes, besides that i think it's ok

[henryiii]

Okay, I'll rerun the formatter soon.

[henryiii]

Looks like the 5.0.1 version of clang-format is a bit finicky too. I'll play with cleanup tomorrow, and will probably add a couple of clang-format-off directives (or switch to a docker clang-format on Travis and use unibeatify's version).

[henryiii]

By the way, I believe the API will change a bit with #240: Instead of an extra argument in add_option, you would do it like this now:

add_option("--thing", vector)->delimiter(',');

As a bonus, the delimiter is now supported by validators and more.