Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ! operator to Validators for checking a false condition #230

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Feb 20, 2019

This PR is the first of a series pulled from #229.
If merged this PR will add support for a ! operator on Validators.

For example

app.add_option("--file", filename)->check(!CLI::ExistingFile);

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #230   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2057   2072   +15     
=====================================
+ Hits         2057   2072   +15
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <ø> (ø) ⬆️
include/CLI/Validators.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0bb1c...a7d1aef. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #230   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2057   2102   +45     
=====================================
+ Hits         2057   2102   +45
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <ø> (ø) ⬆️
include/CLI/Validators.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <0%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <0%> (ø) ⬆️
include/CLI/TypeTools.hpp 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0bb1c...04a9c9d. Read the comment docs.

@henryiii henryiii merged commit 571fb07 into CLIUtils:master Feb 20, 2019
@phlptp phlptp deleted the Not_validator_support branch February 21, 2019 15:48
@henryiii henryiii added this to the v1.8 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants