Add classification type traits #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st overload to use
phlptp
force-pushed
the
add_classification_type_traits
branch
from
ebbeeca
to
cea28dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2935 2939 +4
=====================================
+ Hits 2935 2939 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2935 2939 +4
=====================================
+ Hits 2935 2939 +4
Continue to review full report at Codecov.
|
henryiii
approved these changes
Jul 30, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to clean up the SFINAE used for the internal lexical cast. Define a classify_object type trait that categorizes types into a number of different categories, then the lexical_cast functions use that trait for distinguishing how to do the conversions.
The main changes in this on are in TypeTools.hpp