-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang-tidy fixes #360
Clang-tidy fixes #360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3353 3354 +1
=====================================
+ Hits 3353 3354 +1
Continue to review full report at Codecov.
|
14c02b7
to
cd7dae2
Compare
The CI should be checking clang-tidy (though it might have been lost during the transition of formatting to GitHub Actions). |
I remember getting some PR's where the clang-tidy checks were triggered recently so I think it is still working, but I was also under the impression that was only checking a pretty limited subset of the clang-tidy checks and specifically ones where there was an auto fix that was possible. |
This PR fixes the clang-tidy issues in Option.hpp.