Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-tidy fixes #360

Merged
merged 5 commits into from
Dec 5, 2019
Merged

Clang-tidy fixes #360

merged 5 commits into from
Dec 5, 2019

Conversation

cbachhuber
Copy link
Collaborator

This PR fixes the clang-tidy issues in Option.hpp.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #360   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3353   3354    +1     
=====================================
+ Hits         3353   3354    +1
Impacted Files Coverage Δ
include/CLI/Validators.hpp 100% <ø> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7b29f...4426965. Read the comment docs.

include/CLI/Option.hpp Outdated Show resolved Hide resolved
include/CLI/Option.hpp Outdated Show resolved Hide resolved
@henryiii
Copy link
Collaborator

henryiii commented Dec 4, 2019

The CI should be checking clang-tidy (though it might have been lost during the transition of formatting to GitHub Actions).

@phlptp
Copy link
Collaborator

phlptp commented Dec 4, 2019

I remember getting some PR's where the clang-tidy checks were triggered recently so I think it is still working, but I was also under the impression that was only checking a pretty limited subset of the clang-tidy checks and specifically ones where there was an auto fix that was possible.

@henryiii henryiii merged commit d9379cc into CLIUtils:master Dec 5, 2019
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
@cbachhuber cbachhuber deleted the clang-tidy-fixes branch January 25, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants