Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a cmakeLists for the book #374

Merged
merged 6 commits into from
Dec 28, 2019
Merged

add a cmakeLists for the book #374

merged 6 commits into from
Dec 28, 2019

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Dec 27, 2019

If merged this pull request will add a target in MSVC to link the book into the visual studio UI so it can be edited easily inside visual Studio.

adds a CMakeLists in the book directory and an add_subdirectory command to use it inside the main CMakeLists.txt file.

This doesn't actually build anything new just makes it much easier to edit the book in visual studio.

@phlptp
Copy link
Collaborator Author

phlptp commented Dec 27, 2019

I was starting to work with this as part of the config_file update but it seemed like something that could stand alone as it wasn't directly related to any config file changes.

Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using a glob? I don’t think I’d remember to add a new md file to the cmake lists.

book/CMakeLists.txt Outdated Show resolved Hide resolved
…the files. Also add a check to make sure book directory exists which seems to be important on appveyor
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #374   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3398   3389    -9     
=====================================
- Hits         3398   3389    -9
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <0%> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b979d3a...e9e38a4. Read the comment docs.

@phlptp
Copy link
Collaborator Author

phlptp commented Dec 27, 2019

also it appears a new doxygen release was made (12-27-19) so the build script for doxygen broke

@henryiii henryiii merged commit 73950eb into CLIUtils:master Dec 28, 2019
@henryiii henryiii deleted the book_target branch December 28, 2019 22:59
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants