Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy correctly run by CI #390

Merged
merged 3 commits into from
Jan 6, 2020
Merged

clang-tidy correctly run by CI #390

merged 3 commits into from
Jan 6, 2020

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jan 6, 2020

Helping with #389, orthogonal changes. Clang-tidy now run by CI, warnings are shown. Will fix two errors as well in preparation for CLI11 1.9. CLANG_TIDY_FIX reworked into CLI11_CLANG_TIDY and CLI11_CLANG_TIDY_OPTIONS.

@cbachhuber
Copy link
Collaborator

Awesome, thanks a lot!

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@59052a6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #390   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     12           
  Lines             ?   3565           
  Branches          ?      0           
=======================================
  Hits              ?   3565           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <ø> (ø)
include/CLI/Validators.hpp 100% <100%> (ø)
include/CLI/Config.hpp 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59052a6...df0682b. Read the comment docs.

Used '-DCLI11_CLANG_TIDY=ON -DCLI11_CLANG_TIDY_OPTIONS=-fix;-checks=google-explicit-constructor"'
@henryiii henryiii added this to the v1.9 milestone Jan 6, 2020
@henryiii henryiii marked this pull request as ready for review January 6, 2020 19:16
@henryiii henryiii merged commit 5d07c46 into master Jan 6, 2020
@henryiii henryiii deleted the henryiii-clang-tidy branch January 6, 2020 19:16
@cbachhuber cbachhuber mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants