Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set a footer in the description #42

Merged
merged 2 commits into from
Nov 20, 2017

Conversation

lambdafu
Copy link
Contributor

Let's see what you think :) Setting a footer for a bug report address or other notes is common enough that I think it should be supported without subclassing. If you agree, here is a simple implementation that does the trick for me.

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1168   1173    +5     
  Branches      239    240    +1     
=====================================
+ Hits         1168   1173    +5
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b02682...50c5529. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1168   1171    +3     
  Branches      239    240    +1     
=====================================
+ Hits         1168   1171    +3
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b02682...c9a3ee5. Read the comment docs.

@henryiii
Copy link
Collaborator

I think these both look good. Will check and merge tomorrow. Don't worry about the formatting check, I can run clang-format.

@henryiii henryiii merged commit 79cd791 into CLIUtils:master Nov 20, 2017
@henryiii
Copy link
Collaborator

Thanks! I already have a use case, I believe, in a program I'm working on! 👍

@henryiii henryiii added this to the v1.3 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants