The help flag didn't get processed when a config file was required. #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his fixes this issue.
phlptp
force-pushed
the
help_config_required
branch
from
a16e81a
to
47eaa2a
Compare
henryiii
reviewed
Jun 21, 2021
Comment on lines
+2251
to
+2271
| CLI::FileError fe("ne"); | ||
| bool caught_error{false}; | ||
| try { | ||
| // the config file might generate a FileError but that should not be processed until later in the process | ||
| // to allow for help, version and other errors to generate first. | ||
| _process_config_file(); | ||
| // process env shouldn't throw but no reason to process it if config generated an error | ||
| _process_env(); | ||
| } catch(const CLI::FileError &fe2) { | ||
| fe = fe2; | ||
| caught_error = true; | ||
| } | ||
| // callbacks and help_flags can generate exceptions which should take priority over the config file error if one | ||
| // exists | ||
| _process_callbacks(); | ||
| _process_help_flags(); | ||
|
|
||
| if(caught_error) { | ||
| throw CLI::FileError(std::move(fe)); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd be tempted to use a unique_ptr here (really need an optional), but this should get refactored by the error handling update whenever that comes, so I think this is fine.
github-actions
bot
added
needs changelog
henryiii
removed
needs README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #553