Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a more clear force callback #631

Merged
merged 13 commits into from
Sep 20, 2021

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Aug 2, 2021

and callback on parse modifier for options.

The method of forcing a callback that exists is not clear from the issues raised around it. This should clarify that ability and make it more explicit. It also adds an ability to trigger the callback for each parse of an option. This opens up new avenues of processing and CLI modification as well as inline validation.

@phlptp
Copy link
Collaborator Author

phlptp commented Aug 2, 2021

TODO:

  • test cases
  • docs
  • book updates
  • pass checks

@phlptp phlptp marked this pull request as ready for review August 11, 2021 17:58
include/CLI/Option.hpp Outdated Show resolved Hide resolved
@henryiii henryiii merged commit 6c49c29 into CLIUtils:master Sep 20, 2021
@henryiii henryiii deleted the option_callback_additions branch September 20, 2021 14:23
@github-actions github-actions bot added the needs changelog Hasn't been added to the changelog yet label Sep 20, 2021
@henryiii
Copy link
Collaborator

WIP icons missed, added in #638.

@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants