max/min macro conflict #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the 2.1 release I could finally get rid of my custom version of CLI11 in HELICS. Ran into the issue of macros on Windows which this PR fixes. |
henryiii
reviewed
Sep 23, 2021
… and max in the validators.
phlptp
force-pushed
the
max_macro_conflict
branch
from
1d08fff
to
2a02245
Compare
github-actions
bot
added
needs changelog
henryiii
removed
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some potential conflicts when using some validators with some windows headers which define max and min as macros.