add a few tests related to github issues #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlptp
force-pushed
the
issue_checks
branch
3 times, most recently
from
ec4fb28
to
1603ccb
Compare
|
Try to address #669 |
|
Closes #670 |
This was
linked to
issues
Nov 12, 2021
I don't like embedding an English label like this into CLI11; it's nice to avoid text that might need to be translated. Argparse uses "[XXXX]", that might be clearer that the current form? |
henryiii
approved these changes
Nov 18, 2021
…X, this was confusing in some cases particularly with flags or with multiple option names. Now is [default=XXXX] which makes it clearer what the value represents.
henryiii
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test related to issue #556, #569, #551
Changes the way default_str is displayed in the help messages from "=XXXX" to "[XXXX]" to make it clearer what the purpose of the value is.