remove the symbolic link in the meson test #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlptp
force-pushed
the
remove_symbolic_link
branch
4 times, most recently
from
d4277ae
to
0523377
Compare
phlptp
force-pushed
the
remove_symbolic_link
branch
from
0523377
to
d9cc022
Compare
phlptp
force-pushed
the
remove_symbolic_link
branch
2 times, most recently
from
f208055
to
d1f9b90
Compare
|
Calling it |
|
trying the mkdir now |
|
looks like the mkdir from the command line works as well, so that is probably the best solution here |
|
Note: the symlink should be deleted after the test or the problem with gitlab will persist if someone has a gitlab CI executing that test as a submodule. in my case since I am not executing the tests, I think that would work |
phlptp
force-pushed
the
remove_symbolic_link
branch
from
a2b4f1d
to
a198309
Compare
Why would gitlab CI pick up a line from Azure pipelines? |
henryiii
reviewed
Jan 28, 2022
henryiii
approved these changes
Jan 28, 2022
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
github-actions
bot
added
needs changelog
henryiii
removed
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the symbolic link for Issue #696
Add a symlink generation command in the meson CI test