-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negated flag config files #775
Conversation
Codecov ReportBase: 99.06% // Head: 99.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 99.06% 99.19% +0.12%
==========================================
Files 16 16
Lines 3964 3967 +3
==========================================
+ Hits 3927 3935 +8
+ Misses 37 32 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yeah, we really need to get back to 100% - coverage much less useful when it's not 100%, because it can produce false positives. |
I think the switch to a compiled library(possibility) changed the code coverage. Looks like there are sections of missing coverage that are pretty old. Anyway getting back to 100% is going to be a long process. |
I think it mostly happened about a year ago when we lost Travis, new PRs stopped being checked for coverage so it started slipping. When I recently renabled it (before the compiled change), that's when I discovered the coverage had slipped. There might have been even more coverage losses due to the change, as well. :/ No rush, probably something we can work on once in a while. |
Fix Issue #773
add some coverage tests