Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more tests for coverage #781

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Sep 29, 2022

This PR adds some more coverage tests

Also fixes some confusing error situations with config files, that came up while trying some tests for coverage.

@henryiii
Copy link
Collaborator

Hmm, something is broken:

[2022-09-29T13:27:00.234Z] ['info'] ->  Issue detecting commit SHA. Please run actions/checkout with fetch-depth > 1 or set to 0
[27](https://github.com/CLIUtils/CLI11/actions/runs/3151673634/jobs/5125925566#step:8:28)
[2022-09-29T13:27:00.236Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=uploader-0.3.2&token=*******&branch=coverage_tests&build=3151673634&build_url=https%3A%2F%2Fgithub.com%2FCLIUtils%2FCLI11%2Factions%2Fruns%2F3151673634&commit=8065aceb23387a087e894e738dc361f92e5f0302&job=Tests&pr=781&service=github-actions&slug=CLIUtils%2FCLI11&name=&tag=&flags=&parent=
[28](https://github.com/CLIUtils/CLI11/actions/runs/3151673634/jobs/5125925566#step:8:29)
[2022-09-29T13:27:00.562Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

@henryiii
Copy link
Collaborator

Trying a couple of things to see if I can fix coverage reporting.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 99.19% // Head: 99.29% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (931e730) compared to base (dcbcb47).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   99.19%   99.29%   +0.10%     
==========================================
  Files          16       16              
  Lines        3967     3973       +6     
==========================================
+ Hits         3935     3945      +10     
+ Misses         32       28       -4     
Impacted Files Coverage Δ
include/CLI/impl/App_inl.hpp 99.20% <100.00%> (+<0.01%) ⬆️
include/CLI/ConfigFwd.hpp 98.11% <0.00%> (-1.89%) ⬇️
include/CLI/Option.hpp 100.00% <0.00%> (+0.47%) ⬆️
include/CLI/impl/Option_inl.hpp 99.74% <0.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henryiii
Copy link
Collaborator

Working. :)

@henryiii henryiii merged commit fd30b59 into CLIUtils:main Sep 29, 2022
@henryiii henryiii deleted the coverage_tests branch September 29, 2022 15:48
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Sep 29, 2022
@henryiii henryiii removed needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants