tweak the parsing of files for flags with disable_flag_override #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cally allow true as a valid value to be interpreted as the default in that case
Codecov ReportBase: 99.42% // Head: 99.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 16 16
Lines 3977 3985 +8
=======================================
+ Hits 3954 3962 +8
Misses 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
henryiii
approved these changes
Nov 30, 2022
github-actions
bot
added
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow true as a valid value to be interpreted as the default in that case.
Ran into a situation where the user was very confused by an error in a config file. Basically had a flag with
disable_flag_overridethat was using different hidden values. The user tried to specify it in a config file and expected "flag":true to work and gave a confusing error.This PR tweaks things a little so a value equivalent to "true" in a config file will get properly converted to the appropriate default value and remove a confusing error condition.