Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for out of bounds long long #807

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Nov 27, 2022

Resolve Issue #801 and add a test based on discussion #806

Added ERANGE clear and check for unsigned and signed integer and added a check for - as the first value of the string for unsigned integers(this only mattered for uint64_t for 32 bit or smaller unsigned the existing check worked fine.

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 99.42% // Head: 99.42% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7f7cee6) compared to base (b16c8c8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          16       16           
  Lines        3977     3983    +6     
=======================================
+ Hits         3954     3960    +6     
  Misses         23       23           
Impacted Files Coverage Δ
include/CLI/TypeTools.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phlptp phlptp merged commit ca9a128 into CLIUtils:main Nov 30, 2022
@phlptp phlptp deleted the out_of_bounds_longlong branch November 30, 2022 23:41
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Nov 30, 2022
@henryiii henryiii removed the needs README Needs to be mentioned in the README label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Hasn't been added to the changelog yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants