Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase min CMake to 3.5 #898

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix: increase min CMake to 3.5 #898

merged 1 commit into from
Jun 28, 2023

Conversation

henryiii
Copy link
Collaborator

CMake 3.27 will start warning if this is older than 3.5.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dce7983) 99.46% compared to head (0b7ab0d) 99.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          18       18           
  Lines        4095     4095           
=======================================
  Hits         4073     4073           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henryiii henryiii requested a review from phlptp June 28, 2023 20:05
Copy link
Collaborator

@phlptp phlptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 3.5 keep this running on a default Ubuntu 18.04 and RHEL 6 so should be good

@henryiii henryiii merged commit f07a8cc into main Jun 28, 2023
@henryiii henryiii deleted the henryiii/fix/cmakemin branch June 28, 2023 20:24
@github-actions github-actions bot added the needs changelog Hasn't been added to the changelog yet label Jun 28, 2023
@henryiii
Copy link
Collaborator Author

Checking https://cliutils.gitlab.io/modern-cmake/chapters/intro/installing.html, 18.04 used 3.10. 16.04 used 3.5. Though both are EoL, both should be fine. :)

RHEL 6 is weird, as "cmake" continued to point at 2.8, as if 3 was a breaking change (it wasn't). Guessing this is referring to EPEL 6, which is 3.6.

@phlptp
Copy link
Collaborator

phlptp commented Jun 28, 2023

If I remember right RHEL 6 had a cmake3 package that had cmake 3.6, and it was a bit weird but at least it was available as a package. Been a while since I used that version though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Hasn't been added to the changelog yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants