Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a reverse multi option policy #918

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Aug 22, 2023

use it for the default in set_config and simplify and add more flexibility to the the config processing, and potentially in other options as well.

The reverse policy returns a vector but in reversed order from normal. This is what we want in the config processing

Inspired by #862, and updated with recent code changes.

…ig and simplify the config processing.

Co-authored-by: Volker Christian <me@vchrist.at>
@phlptp
Copy link
Collaborator Author

phlptp commented Aug 22, 2023

@VolkerChristian I think this does what you were thinking in #862? I borrowed some code from that PR and added you as a co-author.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6da4ff5) 99.46% compared to head (cca6e64) 99.46%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          18       18           
  Lines        4108     4118   +10     
=======================================
+ Hits         4086     4096   +10     
  Misses         22       22           
Files Changed Coverage Δ
include/CLI/App.hpp 100.00% <ø> (ø)
include/CLI/Option.hpp 100.00% <ø> (ø)
include/CLI/impl/App_inl.hpp 99.31% <100.00%> (+<0.01%) ⬆️
include/CLI/impl/Option_inl.hpp 99.75% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii changed the title add a reverse multi option policy, feat: add a reverse multi option policy Sep 15, 2023
@henryiii henryiii merged commit f0e4055 into CLIUtils:main Sep 15, 2023
46 checks passed
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants