Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional tests for coverage, #928

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 5, 2023

Add some additional tests to try to get test coverage back to 100%

refactor the positional parsing to reduce code duplication

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
include/CLI/impl/App_inl.hpp 100.00% <100.00%> (+0.83%) ⬆️
include/CLI/impl/Config_inl.hpp 100.00% <100.00%> (+1.68%) ⬆️

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@phlptp
Copy link
Collaborator Author

phlptp commented Oct 6, 2023

@henryiii I am going to merge this in one day unless you object. (2023-10-7)
There are no API changes only some code refactoring, new tests, and a fix for an edge case on specifically formatted inline comments on flags. then I will try to tackle the coverage in some of the other files, but this fixes app_inl and config_inl to 100% coverage.

@henryiii
Copy link
Collaborator

henryiii commented Oct 6, 2023

I've already approved so you can merge any time (you don't have to have my approval unless it's potentially controversial or something). And these sorts of cleanups & added tests don't need much review, IMO.

@phlptp phlptp merged commit c99918e into CLIUtils:main Oct 6, 2023
50 checks passed
@phlptp phlptp deleted the coverage_tests branch October 6, 2023 15:38
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants