Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting new gflags library #108

Closed
agrayver opened this issue Jan 25, 2015 · 2 comments
Closed

Supporting new gflags library #108

agrayver opened this issue Jan 25, 2015 · 2 comments
Assignees

Comments

@agrayver
Copy link

gflags 2.1.1 does not seem to have namespace "google" anymore, instead it was renamed to "gflags". Simply replacing former with latter in all test/example files solved the problem.

@beniz beniz self-assigned this Jan 26, 2015
@beniz
Copy link
Collaborator

beniz commented Jan 26, 2015

A well known annoyance by gflags indeed! And a good opportunity to tackle it once and for all.

There's no good ways of fixing this, but a 'hack' used by others as well (http://caffe.berkeleyvision.org/doxygen/common_8hpp_source.html).

The code is now ready for gflags 2.1 but it is recommended to use the following in external programs that use gflags:

#include <gflags/gflags.h>
#ifndef GFLAGS_GFLAGS_H_
namespace gflags = google;
#endif  // GFLAGS_GFLAGS_H_

gflags::ParseCommandLineFlags(&argc, &argv, true);

@beniz
Copy link
Collaborator

beniz commented Jan 26, 2015

This is active on 'dev' branch.

@beniz beniz closed this as completed Jan 26, 2015
andrewsali pushed a commit to andrewsali/libcmaes that referenced this issue Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants