-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EASI-3172] Upgrade go from 1.18 to 1.21 #2188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall; I have two small comments, but they're not significant enough to hold up this PR. We might also want to reference installing our current version of Go in docs/dev_environment_setup.md
; right now it just says to install the latest version of Go. Up to you, though.
Once this gets merged, it'd be a good idea to let the team know to upgrade their locally installed versions of Go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with updates to docs.
Side note - it looks like the issues with that gosec
rule might have been fixed by securego/gosec#1017, but we can look into that later.
EASI-3172
Changes and Description
.git
directory in docker causes some issues with Go 1.21)How to test this change
scripts/dev up
, ensuring the app can buildscripts/dev db:seed
to seed the DBPR Author Review Checklist
PR Reviewer Guidelines