Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Add env vars for cache time and to bypass cache #2576

Merged
merged 3 commits into from
May 10, 2024

Conversation

mynar7
Copy link
Contributor

@mynar7 mynar7 commented May 10, 2024

NOREF

Changes and Description

  • Adds the CEDAR_CACHE_EXPIRE_TIME environmental variable to allow for setting the length of time the nginx proxy caches requests without directly modifying the nginx config. Setting a new cache time will require a manual redeploy of the nginx proxy though due to GitHub action only monitoring for changes to the /cedarproxy folder or the swagger client.
  • Adds the CEDAR_CORE_SKIP_PROXY env var that allows for bypassing the nginx proxy if desired.
    • Note: This would require a manual redeploy though since the variable is read in on server start. It might make sense to revisit how we implement env vars or use launchdarkly instead.
  • Adds a proxy_cache_use_stale rule to nginx that allows for returning older responses in the event of timeouts, errors, etc.

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@mynar7 mynar7 requested review from ClayBenson94 and Jdwoodson May 10, 2024 18:56
@mynar7 mynar7 requested review from a team as code owners May 10, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants