Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4614] Initial email work for GRB Discussions #2875

Conversation

downeyn-cms
Copy link
Contributor

EASI-4614 EASI-4638 EASI-4645 EASI-4646

Description

  • Initial work for the emails generated by the upcoming GRB review discussion functionality
  • Added templates and handlers for the emails generated by specific actions (replies and tagging)
  • This work is not complete yet. as some of the final details are blocked by the discussion functionality (e.g. discussion ID, user names, group names, etc.)

How to test this change

  • This is a tough one to test locally, any ideas on how to expand on the testing I already added would be welcome
  • Full testing is blocked by implementation of the discussion functionality

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@downeyn-cms downeyn-cms requested a review from a team as a code owner November 5, 2024 22:36
@downeyn-cms downeyn-cms requested review from mynar7 and removed request for a team November 5, 2024 22:36
Copy link
Contributor

@mynar7 mynar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these new emails to the email script file?

Also discussion content is going to be HTML so we can update these emails to use that model instead of strings.

@samoddball samoddball merged commit 4b99bca into feature/EASI-4614_grb_discussions Nov 26, 2024
12 checks passed
@samoddball samoddball deleted the EASI-4614/grb-review-discussion-emails branch November 26, 2024 19:44
@samoddball samoddball mentioned this pull request Nov 27, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants